Re: [RFC/PATCHv2] git-web--browse: avoid the use of eval

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 20, 2011, 19:35 UTC
Message-ID: <7vvcsn57na.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110920184939.GA17322@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

>> The example in t/README has has a copyright notice which is why I put
>> one in but I don't consider the test (or the fix itself) to actually be
>> copyrightable. If I wasn't creating a new file I wouldn't have bothered
>> putting anything in (other than the testcase).
>
> Yeah, that's why I said I don't know if we have a policy. We clearly
> have a lot of copyright statements, but they are all horribly out of
> date. I was hoping Junio might weigh in.

To be honest, I do not care very much either way. From the licensing point of view we know everything is covered by the top-level COPYING unless otherwise noted explicitly in an individual file (which is not the case for this patch anyway), and even without the copyright notice we can trace where the files come from with "git log", so these three lines in a small test file are essentially noise, not very useful but are not irritating enough to warrant an effort from me to amend it out.

I do have a mild objection to a patch that adds a new copyright notice line to an existing file when it adds only a few new lines, though. When the code is refactored and these new lines are made unneeded, it is likely that nobody would bother removing that copyright notice line that names the author of the patch that added these lines.