Re: [PATCH] git-web--browse: invoke kfmclient directly
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 19, 2011, 22:28 UTC
- Message-ID
- <7vk49488vi.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20110919222325.GA4056@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 10 quoted lines
> Yeah. Doing: > > eval '$browser_cmd' > > will do the whitespace-breaking we want, but it won't interpret actual > shell magic characters, which we need in order to be compatible with > other parts of git (which typically use "sh -c ..."). E.g.: > > foo=worked > browser_cmd='echo $foo'
Yikes, I forgot that we do that. You are right.