Re: [RFC/PATCHv2] git-web--browse: avoid the use of eval

From: Jeff King <peff@peff.net>
Date: Sep 20, 2011, 18:49 UTC
Message-ID: <20110920184939.GA17322@sigill.intra.peff.net>
In-Reply-To: <4E78572E.6030105@gmail.com>

On Tue, Sep 20, 2011 at 09:04:46PM +1200, Chris Packham wrote:

Show 8 quoted lines

> > Although other projects do use "cc" in the commit message, I think we
> > don't usually bother adding this noise in the git project. The cc
> > headers in your email are enough.
> 
> That's more for git send-email's benefit than anything else. I'm working
> on a laptop with a touchpad (and a cat) so the less switching between
> editor and MUA the better. Any better suggestions for tracking Cc's for
> git send-email?

It would depend on your workflow, I think. You can use --cc to add headers to format-patch. You could get very fancy and store them in git-notes or somewhere else, and then pull them in with send-email's cc-cmd option. But I suspect you just want to stick them in the commit message one time and then have it used each time.

If put them after the double-dash line in your commit message, like:

  subject

  body
  ---
  cc: whoever

Then that will be included verbatim in the mail by format-patch, send-email will respect the cc line, and those lines will be dropped by "git am" when Junio applies the patch (they are still a slight noise to readers of the mail, but at least they don't make it into the commit history).

> The example in t/README has has a copyright notice which is why I put
> one in but I don't consider the test (or the fix itself) to actually be
> copyrightable. If I wasn't creating a new file I wouldn't have bothered
> putting anything in (other than the testcase).

Yeah, that's why I said I don't know if we have a policy. We clearly have a lot of copyright statements, but they are all horribly out of date. I was hoping Junio might weigh in.

-Peff