Re: [PATCH] Implement git-quiltimport (take 2)

From: Eric W. Biederman <ebiederm@xmission.com>
Date: May 20, 2006, 02:42 UTC
Message-ID: <m1ac9dv2ld.fsf@ebiederm.dsl.xmission.com>
In-Reply-To: <20060519235825.GA3289@kroah.com>

Greg KH <greg@kroah.com> writes:

Show 15 quoted lines

> On Thu, May 18, 2006 at 04:48:26AM -0600, Eric W. Biederman wrote:
>> 
>> Yes, a smaller patch series, that is what I meant.
>> Most quilt trees that I know about are  small.
>
> $ quilt series | wc -l
> 207
>
> And that is about "normal" for me.  Sometimes it grows to about 500+
> patches, but that only happens when there's a longer kernel release
> cycle.
>
> Another tree that I work on all the time is about 700+ patches, and yet
> another 2000+.  So you might re-evaluate your statement about "small"
> quilt series :)

Sure. On fixing the upstream attribution issue you and Andi Kleen look like people that are worth talking to, as there were several patches in Andrews tree from both of you that were lacking attribution.

> In looking at your script, it doesn't seem to be able to handle patches
> in quilt that are in mbox format.  Any thoughts to allow this to handle
> the attribution properly?

Mbox format but one patch per file, or multiple patches in one mbox file?

If it is one patch per file but with mbox headers, it is relatively simple to teach git-mailinfo to parse things in a slightly more intelligent way. I played with that but I didn't have any patches that helped with.

Show 6 quoted lines

> Right now my development flow has me converting my quilt tree to one big
> mbox file and then using 'git applymbox' to import it before asking
> Linus to pull from it.
>
> With your script I could skip at least one step, which would save me
> some time...

Sure. That is the point of making it generic.

Eric