Re: [PATCH] Implement git-quiltimport (take 2)

From: Greg KH <greg@kroah.com>
Date: May 20, 2006, 21:32 UTC
Message-ID: <20060520213257.GH24672@kroah.com>
In-Reply-To: <m1ac9dv2ld.fsf@ebiederm.dsl.xmission.com>

On Fri, May 19, 2006 at 08:42:38PM -0600, Eric W. Biederman wrote:

Show 21 quoted lines

> Greg KH <greg@kroah.com> writes:
> 
> > On Thu, May 18, 2006 at 04:48:26AM -0600, Eric W. Biederman wrote:
> >> 
> >> Yes, a smaller patch series, that is what I meant.
> >> Most quilt trees that I know about are  small.
> >
> > $ quilt series | wc -l
> > 207
> >
> > And that is about "normal" for me.  Sometimes it grows to about 500+
> > patches, but that only happens when there's a longer kernel release
> > cycle.
> >
> > Another tree that I work on all the time is about 700+ patches, and yet
> > another 2000+.  So you might re-evaluate your statement about "small"
> > quilt series :)
> 
> Sure.  On fixing the upstream attribution issue you and Andi Kleen 
> look like people that are worth talking to, as there were several
> patches in Andrews tree from both of you that were lacking attribution.

Yes, I know I don't put any headers on patches I create until they are ready to be sent upstream to Linus. I'll try to be better about that in the future, sorry.

Show 5 quoted lines

> > In looking at your script, it doesn't seem to be able to handle patches
> > in quilt that are in mbox format.  Any thoughts to allow this to handle
> > the attribution properly?
> 
> Mbox format but one patch per file, or multiple patches in one mbox file?

The patches are already in mbox format in each file, but I dump them all together into one big one, to preserve the proper order as defined in the quilt series file so that git gets it right.

> If it is one patch per file but with mbox headers, it is relatively
> simple to teach git-mailinfo to parse things in a slightly more intelligent
> way.  I played with that but I didn't have any patches that helped with.

Hm, I'll try playing with that.

If you want, just grab my quilt trees from kernel.org and play with them, they should all be in mbox format for the individual patches (with some exceptions as noted above, just kick me about them to get me to fix them...)

thanks,

greg k-h