git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Implement git-quiltimport (take 2)

From
Greg KH <greg@kroah.com>
Date
May 19, 2006, 23:58 UTC
Message-ID
<20060519235825.GA3289@kroah.com>
In-Reply-To
<m1ejyr38xx.fsf@ebiederm.dsl.xmission.com>
On Thu, May 18, 2006 at 04:48:26AM -0600, Eric W. Biederman wrote:
Show 35 quoted lines
> Junio C Hamano <junkio@cox.net> writes:
> 
> > ebiederm@xmission.com (Eric W. Biederman) writes:
> >
> >> Junio C Hamano <junkio@cox.net> writes:
> >>
> >>> What's the expected workflow for you to work on a 1300 patch
> >>> series you get from Andrew in the next installment to deal with
> >>> 88 unattributed patches?  Answer the question 88 times and make
> >>> sure you get the answers right every time?  Or abort and
> >>> hand-edit them to help mailinfo to notice the correct
> >>> attribution and re-run?
> >>
> >> For the internal consumption case it isn't a big deal.  I
> >> can specify --author with something bogus and it works. 
> >
> > Yes.
> >
> >>> I know I am guilty of suggesting "going interactive", but I have
> >>> a feeling that having an optional file that maps patch-name to
> >>> author might be easier to work with.  If the old patches are
> >>> recycled in the updated -mm set, you probably can reuse the
> >>> mapping for them, adding entries for newly introduced "unnamed"
> >>> patches as needed.
> >>
> >> Short of getting the script where it has a sane restart in the
> >> middle mode going interactive and asking questions makes a lot
> >> of sense.  Especially with smaller trees.
> >
> > Yes perhaps on smaller trees, but that does not mean much.  For
> > smaller trees and/or smaller patch series almost anything would
> > do.
> 
> Yes, a smaller patch series, that is what I meant.
> Most quilt trees that I know about are in needed small.

$ quilt series | wc -l 207

And that is about "normal" for me. Sometimes it grows to about 500+ patches, but that only happens when there's a longer kernel release cycle.

Another tree that I work on all the time is about 700+ patches, and yet another 2000+. So you might re-evaluate your statement about "small" quilt series :)

In looking at your script, it doesn't seem to be able to handle patches in quilt that are in mbox format. Any thoughts to allow this to handle the attribution properly?

Right now my development flow has me converting my quilt tree to one big mbox file and then using 'git applymbox' to import it before asking Linus to pull from it.

With your script I could skip at least one step, which would save me some time...

thanks,
greg k-h
Previous: Eric W. BiedermanNext: Eric W. Biederman
Message 12 of 24 in “Implement git-quiltimport”
  1. Implement git-quiltimportEric W. Biederman, May 16, 2006
  2. Linus TorvaldsMay 16, 2006
  3. Eric W. BiedermanMay 16, 2006
  4. Junio C HamanoMay 16, 2006
  5. Eric W. BiedermanMay 17, 2006
  6. Junio C HamanoMay 17, 2006
  7. Implement git-quiltimport (take 2)Eric W. Biederman, May 17, 2006
  8. Junio C HamanoMay 17, 2006
  9. Eric W. BiedermanMay 17, 2006
  10. Junio C HamanoMay 17, 2006
  11. Eric W. BiedermanMay 18, 2006
  12. Greg KHMay 19, 2006
  13. Eric W. BiedermanMay 20, 2006
  14. Greg KHMay 20, 2006
  15. Eric W. BiedermanMay 21, 2006
  16. Junio C HamanoMay 21, 2006
  17. Eric W. BiedermanMay 21, 2006
  18. Junio C HamanoMay 21, 2006
  19. Eric W. BiedermanMay 21, 2006
  20. Greg KHJun 1, 2006
  21. Eric W. BiedermanJun 2, 2006
  22. Eric W. BiedermanMay 19, 2006
  23. Implement a --dry-run option to git-quiltimportEric W. Biederman, May 17, 2006
  24. Linus TorvaldsMay 17, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.