git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Implement git-quiltimport

From
Linus Torvalds <torvalds@osdl.org>
Date
May 17, 2006, 14:28 UTC
Message-ID
<Pine.LNX.4.64.0605170725070.10823@g5.osdl.org>
In-Reply-To
<m13bf95ixo.fsf@ebiederm.dsl.xmission.com>
On Tue, 16 May 2006, Eric W. Biederman wrote:
Show 7 quoted lines
> 
> So what we need for this case really is a way to mark the
> commit objects in such a way that git-fetch or git-merge
> would choke on the commit objects and refuse to merge.
> That way the changes could not easily propagate in the wild.
> Every user would at least have to specify a non-default option,
> that Linus at least would never specify.
No.

What we need is for your git-quiltimport to not generate the bogus commits in the first place!

Make it a damn error already.

If you want to have some stupid default to a non-existing and non-supported user, then do

	git-quiltimport --author="Bad User <baduser@nosuchuser.com>"

and get over it. Don't make the quiltimport script _default_ to a totally idiotic model that will just screw people over.

Or keep it as your personal script. I'm just saying that it should sure as hell not be used by any sane person in the format it is in now. Because, _by_default_, it now does something insane, which is bad bad bad. Which means that it shouldn't be merged by Junio.

		Linus
Previous: Eric W. Biederman
Message 24 of 24 in “Implement git-quiltimport”
  1. Implement git-quiltimportEric W. Biederman, May 16, 2006
  2. Linus TorvaldsMay 16, 2006
  3. Eric W. BiedermanMay 16, 2006
  4. Junio C HamanoMay 16, 2006
  5. Eric W. BiedermanMay 17, 2006
  6. Junio C HamanoMay 17, 2006
  7. Implement git-quiltimport (take 2)Eric W. Biederman, May 17, 2006
  8. Junio C HamanoMay 17, 2006
  9. Eric W. BiedermanMay 17, 2006
  10. Junio C HamanoMay 17, 2006
  11. Eric W. BiedermanMay 18, 2006
  12. Greg KHMay 19, 2006
  13. Eric W. BiedermanMay 20, 2006
  14. Greg KHMay 20, 2006
  15. Eric W. BiedermanMay 21, 2006
  16. Junio C HamanoMay 21, 2006
  17. Eric W. BiedermanMay 21, 2006
  18. Junio C HamanoMay 21, 2006
  19. Eric W. BiedermanMay 21, 2006
  20. Greg KHJun 1, 2006
  21. Eric W. BiedermanJun 2, 2006
  22. Eric W. BiedermanMay 19, 2006
  23. Implement a --dry-run option to git-quiltimportEric W. Biederman, May 17, 2006
  24. Linus TorvaldsMay 17, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.