git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 2/5] fetch+push tests: add missing coverage for 6dcbdc0d661

From
Derrick Stolee <derrickstolee@github.com>
Date
Jun 15, 2022, 12:39 UTC
Message-ID
<ffa6d63c-0efb-d805-dc73-a781e5a92f22@github.com>
In-Reply-To
<RFC-patch-2.5-38af32c5b96-20220615T104503Z-avarab@gmail.com>
On 6/15/22 6:53 AM, Ævar Arnfjörð Bjarmason wrote:
> Add tests that were missing from 6dcbdc0d661 (remote: create
> fetch.credentialsInUrl config, 2022-06-06), we want to test how we
> handle cases where the config comes from a file, and that we handle
> "pushURL" correctly.

The tests use your renamed transfer.credentialsInUrl, but you haven't renamed at this point.

> Currently the "pushURL" case isn't handled at all, i.e. URLs aren't
> warned about in "remote.*pushurl" , only for "remote.*.url".

Good find. I suppose that the second test_expect_success will _fail_ at the point of this patch?

Thanks, -Stolee

Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 4 of 9 in “fix issues in transfer.credentialsInUrl”
  1. 0/5 fix issues in transfer.credentialsInUrlÆvar Arnfjörð Bjarmason, Jun 15, 2022
  2. 1/5 push tests: add a missing "test_line_count"Ævar Arnfjörð Bjarmason, Jun 15, 2022
  3. 2/5 fetch+push tests: add missing coverage for 6dcbdc0d661Ævar Arnfjörð Bjarmason, Jun 15, 2022
  4. Derrick StoleeJun 15, 2022
  5. 3/5 CI: add a linux-BUILD-vars jobÆvar Arnfjörð Bjarmason, Jun 15, 2022
  6. Derrick StoleeJun 15, 2022
  7. 4/5 fetch: stop emitting duplicate transfer.credentialsInUrl=warn warningsÆvar Arnfjörð Bjarmason, Jun 15, 2022
  8. 5/5 transport: check remote.<name>pushurl with transfer.credentialsInUrlÆvar Arnfjörð Bjarmason, Jun 15, 2022
  9. Derrick StoleeJun 15, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.