git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 3/5] CI: add a linux-BUILD-vars job

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jun 15, 2022, 10:53 UTC
Message-ID
<RFC-patch-3.5-d69368c5b39-20220615T104503Z-avarab@gmail.com>
In-Reply-To
<RFC-cover-0.5-00000000000-20220615T104503Z-avarab@gmail.com>

Add a linux-BUILD-vars job, in a preceding commit we fixed a bug that would have been spotted by testing under NO_CURL=Y.

This CI job attempts to unset various settings in config.mak.uname and the Makefile, so that we'll stress our fallbacks and conditionally compiled code as much as possible.

If there is a missing setting here that we can enable under "ubuntu-latest" the omission isn't intentional, this list came from a quick skimming of the relevant parts of the Makefile and config.mak.uname.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 .github/workflows/main.yml |  3 +++
 ci/run-build-and-tests.sh  | 30 ++++++++++++++++++++++++++++++
 2 files changed, 33 insertions(+)
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 3fa88b78b6d..25263c6b17a 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -229,6 +229,9 @@ jobs:
             cc: gcc
             os: ubuntu
             cc_package: gcc-8
+          - jobname: linux-BUILD-vars
+            cc: gcc
+            os: ubuntu
             pool: ubuntu-latest
           - jobname: osx-clang
             cc: clang
diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh
index 8ebff425967..786285c5071 100755
--- a/ci/run-build-and-tests.sh
+++ b/ci/run-build-and-tests.sh
@@ -31,6 +31,36 @@ linux-TEST-vars)
 	export GIT_TEST_WRITE_REV_INDEX=1
 	export GIT_TEST_CHECKOUT_WORKERS=2
 	;;
+linux-BUILD-vars)
+	export NO_CURL=Y
+	export NO_PTHREADS=Y
+	export NO_GETTEXT=Y
+
+	# Undo settings in config.mak.uname
+	export HAVE_ALLOCA_H=
+
+	# Various compat/ fallbacks, with "FAIL" omitted if faking it
+	# doesn't work on Linux.
+	export NO_REGEX=Y
+	export NO_MEMMEM=Y
+	export INTERNAL_QSORT=Y
+	export SNPRINTF_RETURNS_BOGUS=Y
+	export FREAD_READS_DIRECTORIES=Y
+	export OPEN_RETURNS_EINTR=Y
+	export NO_HSTRERROR= # compat/hstrerror.c FAIL
+	export NO_POLL=Y
+	export NO_STRCASESTR=Y
+	export NO_STRTOUMAX=Y
+	export NO_SETENV=Y
+	export NO_UNSETENV=Y
+	export NO_MMAP=Y
+	export NO_PREAD=Y
+	export NEEDS_MODE_TRANSLATION= # compat/stat.c FAIL
+	export NO_IPV6=Y
+	export NO_INET_NTOP=Y
+	export NO_INET_PTON=Y
+	export NO_UNIX_SOCKETS=Y
+	;;
 linux-clang)
 	export GIT_TEST_DEFAULT_HASH=sha1
 	;;
-- 
2.36.1.1239.gfba91521d90
Previous: Derrick StoleeNext: Derrick Stolee
Message 5 of 9 in “fix issues in transfer.credentialsInUrl”
  1. 0/5 fix issues in transfer.credentialsInUrlÆvar Arnfjörð Bjarmason, Jun 15, 2022
  2. 1/5 push tests: add a missing "test_line_count"Ævar Arnfjörð Bjarmason, Jun 15, 2022
  3. 2/5 fetch+push tests: add missing coverage for 6dcbdc0d661Ævar Arnfjörð Bjarmason, Jun 15, 2022
  4. Derrick StoleeJun 15, 2022
  5. 3/5 CI: add a linux-BUILD-vars jobÆvar Arnfjörð Bjarmason, Jun 15, 2022
  6. Derrick StoleeJun 15, 2022
  7. 4/5 fetch: stop emitting duplicate transfer.credentialsInUrl=warn warningsÆvar Arnfjörð Bjarmason, Jun 15, 2022
  8. 5/5 transport: check remote.<name>pushurl with transfer.credentialsInUrlÆvar Arnfjörð Bjarmason, Jun 15, 2022
  9. Derrick StoleeJun 15, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.