From: Derrick Stolee <derrickstolee@github.com>
Date: Wed, 15 Jun 2022 12:39:02 GMT
Subject: Re: [RFC PATCH 2/5] fetch+push tests: add missing coverage for 6dcbdc0d661
Message-ID: <ffa6d63c-0efb-d805-dc73-a781e5a92f22@github.com>
In-Reply-To: <RFC-patch-2.5-38af32c5b96-20220615T104503Z-avarab@gmail.com>

On 6/15/22 6:53 AM, Ævar Arnfjörð Bjarmason wrote:
> Add tests that were missing from 6dcbdc0d661 (remote: create
> fetch.credentialsInUrl config, 2022-06-06), we want to test how we
> handle cases where the config comes from a file, and that we handle
> "pushURL" correctly.

The tests use your renamed transfer.credentialsInUrl, but you haven't
renamed at this point.

> Currently the "pushURL" case isn't handled at all, i.e. URLs aren't
> warned about in "remote.*pushurl" , only for "remote.*.url".

Good find. I suppose that the second test_expect_success will _fail_
at the point of this patch?

Thanks,
-Stolee