git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 0/5] fix issues in transfer.credentialsInUrl

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jun 15, 2022, 10:53 UTC
Message-ID
<RFC-cover-0.5-00000000000-20220615T104503Z-avarab@gmail.com>
This is on top of [1], and given the "rc" phase is an RFC. This:
 * Fixes the issue of the transfer.credentialsInUrl (now renamed) not
   finding passwords in "pushurl" URLs (in my case, the only place
   where I'd actually put a password in a URL in a config...)
 * 1/5 fixes a bug in an existing test, but I didn't think it was
   worth bothering with for 2.37.0.
 * Adds missing test coverage for reading the config from a file, not
   the CLI.
 * 3/5 is a WIP CI target to spot the type of issue I fixed in [2],
   it's not the first time where we have a NO_CURL=Y breakage land on
   master...
 * 4/5 attemps to "really" fix the duplicate warnings we emit, I think
   the approach there is good, especially the part where we shouldn't
   emit it twice in-process.
   But this currently misses e.g. "git ls-remote". I wonder if we
   should just stick that git_config_push_parameter() condition into
   packet_trace_identity() and call it a day.
 * 5/5 fixes the (major) blind spot of the warning missing "pushurl" config.

I think this is all non-RFC quality, except the "ls-remote" case, and us missing tests for that & other transport users that aren't clone/fetch/push.

Derrick: Are you interested in picking this up & pursuing it after the
release, with whatever fix-ups/rewrites etc. that you find
appropriate?
1. https://lore.kernel.org/git/cover-0.2-00000000000-20220615T103852Z-avarab@gmail.com/
2. https://lore.kernel.org/git/cover-0.1-00000000000-20220615T103609Z-avarab@gmail.com/
Ævar Arnfjörð Bjarmason (5):
  push tests: add a missing "test_line_count"
  fetch+push tests: add missing coverage for 6dcbdc0d661
  CI: add a linux-BUILD-vars job
  fetch: stop emitting duplicate transfer.credentialsInUrl=warn warnings
  transport: check remote.<name>pushurl with transfer.credentialsInUrl
 .github/workflows/main.yml |  3 ++
 builtin/clone.c            |  5 ++-
 builtin/fetch.c            |  4 ++
 builtin/push.c             |  6 ++-
 ci/run-build-and-tests.sh  | 30 ++++++++++++++
 remote.c                   | 82 +++++++++++++++++++++++++++-----------
 remote.h                   | 14 +++++++
 t/t5516-fetch-push.sh      | 46 ++++++++++++++++++++-
 t/t5601-clone.sh           |  2 +-
 9 files changed, 164 insertions(+), 28 deletions(-)
-- 
2.36.1.1239.gfba91521d90
Next: Ævar Arnfjörð Bjarmason
Message 1 of 9 in “fix issues in transfer.credentialsInUrl”
  1. 0/5 fix issues in transfer.credentialsInUrlÆvar Arnfjörð Bjarmason, Jun 15, 2022
  2. 1/5 push tests: add a missing "test_line_count"Ævar Arnfjörð Bjarmason, Jun 15, 2022
  3. 2/5 fetch+push tests: add missing coverage for 6dcbdc0d661Ævar Arnfjörð Bjarmason, Jun 15, 2022
  4. Derrick StoleeJun 15, 2022
  5. 3/5 CI: add a linux-BUILD-vars jobÆvar Arnfjörð Bjarmason, Jun 15, 2022
  6. Derrick StoleeJun 15, 2022
  7. 4/5 fetch: stop emitting duplicate transfer.credentialsInUrl=warn warningsÆvar Arnfjörð Bjarmason, Jun 15, 2022
  8. 5/5 transport: check remote.<name>pushurl with transfer.credentialsInUrlÆvar Arnfjörð Bjarmason, Jun 15, 2022
  9. Derrick StoleeJun 15, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.