Re: coccinelle: merge two rules from flex_alloc.cocci

From: Markus Elfring <markus.elfring@web.de>
Date: Nov 13, 2019, 21:10 UTC
Message-ID: <ff240bc1-ae2a-17e5-d149-2d08c5367e96@web.de>
In-Reply-To: <CAN0heSodNonkDK8AT9iJqmWLLCdO0OoHho0ijZOAmri5ren2dw@mail.gmail.com>

Show 6 quoted lines

>>> This script contained two transformation rules for the semantic patch language
>>> which used duplicate code.
>>> Thus combine these rules by using a SmPL disjunction for the replacement
>>> of two identifiers.
>
> My knowledge of coccinelle and cocci rules is basically zero,

Would you like to change this situation eventually?

> but my impression from this list is that running "make coccicheck"
> can be expensive, both in terms of time and memory.

The desired source code analysis to detect possible software transformations needs additional data processing resources. It is usually hoped that corresponding efforts will help with development approaches at other places.

> Do these patches help there in any way?

I hope so to some degree.

How much do you care to avoid code duplication?

> Or could they hurt?

I assume that you ask according to the presented change possibilities for Git's SmPL scripts (and not only for “flex_alloc.cocci”).

Some changes usually contain the risk for undesirable effects. Would you like to clarify each of them in more detail?

Regards, Markus