git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] coccinelle: merge two rules from flex_alloc.cocci

From
MÅMartin Ågren <martin.agren@gmail.com>
Date
Nov 13, 2019, 18:27 UTC
Message-ID
<CAN0heSodNonkDK8AT9iJqmWLLCdO0OoHho0ijZOAmri5ren2dw@mail.gmail.com>
In-Reply-To
<20191112175926.GA41101@generichostname>
Hi Markus,
On Tue, 12 Nov 2019 at 19:02, Denton Liu <liu.denton@gmail.com> wrote:
> I see that you've sent many Coccinelle patches to the mailing list. It
> might be better to send them all together as a single threaded patchset
> so that reviewers will have an easier time finding all of them.
FWIW, I had the same thought.
> > This script contained two transformation rules for the semantic patch language
> > which used duplicate code.
> > Thus combine these rules by using a SmPL disjunction for the replacement
> > of two identifiers.

My knowledge of coccinelle and cocci rules is basically zero, but my impression from this list is that running "make coccicheck" can be expensive, both in terms of time and memory. Do these patches help there in any way? Or could they hurt?

Martin
Previous: Denton LiuNext: Markus Elfring
Message 3 of 9 in “coccinelle: merge two rules from flex_alloc.cocci”
  1. coccinelle: merge two rules from flex_alloc.cocciMarkus Elfring, Nov 12, 2019
  2. Denton LiuNov 12, 2019
  3. Martin ÅgrenNov 13, 2019
  4. Markus ElfringNov 13, 2019
  5. Martin ÅgrenNov 14, 2019
  6. Markus ElfringNov 14, 2019
  7. SZEDER GáborNov 14, 2019
  8. Markus ElfringNov 14, 2019
  9. Junio C HamanoNov 15, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.