Re: coccinelle: merge two rules from flex_alloc.cocci

From: Markus Elfring <markus.elfring@web.de>
Date: Nov 14, 2019, 17:30 UTC
Message-ID: <751e4cc2-e6d0-edfb-b206-4204443a5c62@web.de>
In-Reply-To: <20191114163527.GT4348@szeder.dev>

Show 7 quoted lines

>> Does any test infrastructure (or benchmarks) exist which you would trust for
>> corresponding comparisons of software run time characteristics?
>
> Yes, just run:
>
>   make cocciclean
>   time make contrib/coccinelle/flex_alloc.cocci.patch

Thanks for this suggestion.

> before and after your changes, and include the timing results in the
> commit message if there is a notable difference.

The measurements from my test system might not be representative enough.

Show 7 quoted lines

> FWIW, I did just that with your "coccinelle: merge twelve rules from
> object_id.cocci" patch [1], and the runtime went down from 2m48.610 to
> 2m34.395, a bit over 8% speedup. (with Ubuntu 16.04's Coccinelle
> 1.0.4)
>
>
> [1] https://public-inbox.org/git/6c9962c0-67c1-e700-c145-793ce6498099@web.de/

These numbers seem to be nice. Would a direct reply have been more helpful for the referenced patch than the current subject?

Regards, Markus