Re: coccinelle: merge two rules from flex_alloc.cocci

From: Markus Elfring <markus.elfring@web.de>
Date: Nov 14, 2019, 08:15 UTC
Message-ID: <1d08b49e-1f41-4290-a64b-dad9fd2288de@web.de>
In-Reply-To: <CAN0heSqyGwkeGKv0m_gLDooaUp=gN2_tD7kJYNxeL7LALiPRhQ@mail.gmail.com>

> If you could have some before/after numbers, that would be cool.

Does any test infrastructure (or benchmarks) exist which you would trust for corresponding comparisons of software run time characteristics?

> If you collect your patches into one series, you could at least do measurements
> before/after the series.

How do you think about to check possible improvements by each presented patch according to affected SmPL scripts individually?

> Or if you could make some other sort of claim around "this shouldn't
> affect this-or-that because so-and-so".

I try to avoid such claims. But I provided specific information in my patch descriptions. Do you find any details reasonable there?

> Do you mean whether I would like to clarify the risks I see, or do you
> mean whether I would like you to clarify which you see?

Both. - The discussion will depend also on your change acceptance and desire to extend development in the shown software design directions.

> I've tried to clarify the one I see -- based on passively observing cocci-related
> patches floating around this list.

Thanks for your interest.

> If you see other potential risks, feel free to mention them.

I would prefer a more optimistic view while my software development experiences can influence this considerably.

> You seem to know lots more than I do about these things.

This can be. - But I hope that you can get further inspirations and ideas if you would find any of the published development activities interesting enough.

Regards, Markus