Re: [PATCH v2 9/9] doc/git-rebase: add documentation for fixup [-C|-c] options

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Jan 20, 2021, 14:29 UTC
Message-ID: <fda55ef5-ce37-67c0-f49b-fc2e5172853b@gmail.com>
In-Reply-To: <CAPSFM5f9JJk5xY-f2mNwHjZZfo-=LzSCpA2Q73T-ASGMxfqqeg@mail.gmail.com>

Hi Charvi

On 20/01/2021 12:31, Charvi Mendiratta wrote:

Show 19 quoted lines

> Hi Phillip,
> 
> On Wed, 20 Jan 2021 at 16:34, Phillip Wood <phillip.wood123@gmail.com> wrote:
> 
>>> [...]
>>> Similarly, if we have sequence like `fixup -c`, `fixup -c`, `fixup -c`
>>> then also it will fixup
>>> up all the content and here it allow user to edit the message, so
>>> opens the editor once
>>
>> It is good that we only open the editor once in this case - I'd not
>> thought about chains of `fixup -c` before reading this. Do we have a
>> test to verify that the editor is only opened once?
>>
> 
> No, we don't. But I also agree, it's a good idea to add a test for it.
> I think may be one sequence with 'fixup -C', 'fixup -c', 'fixup -c'
> and the other 'squash' , 'fixup -C', 'fixup -c', is sufficient for
> testing.

Those are both good sequences to test. I think we should check 'fixup -c' 'fixup' as well - with 'squash' 'fixup' we open the editor after the fixup so the user can see all the changes that will be committed when they edit the message, we should do the same for 'fixup -c' 'fixup'. Also 'fixup -c' 'squash' might be worth testing as well.

Best Wishes

Phillip

  Or any other suggestions for testing it ?

> 
> Thanks and regards,
> Charvi
>