Re: [PATCH v5 0/8][Outreachy] rebase -i: add options to fixup command

From: Christian Couder <christian.couder@gmail.com>
Date: Feb 5, 2021, 18:25 UTC
Message-ID: <CAP8UFD0VpgT=mTydWQRmqo9TFQvdfDiXuA1TcwAqG1BtXXdKxA@mail.gmail.com>
In-Reply-To: <CAPSFM5f0Jk03tWCTerZP1JhcMHG4MXjVSZjPKm2uzQYc+cOwsw@mail.gmail.com>

On Fri, Feb 5, 2021 at 10:42 AM Charvi Mendiratta <charvi077@gmail.com> wrote:

> On Fri, 5 Feb 2021 at 13:00, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 10 quoted lines

> > > * changed the flag type from enum todo_item_flags to unsigned
> > > * Replaced fixup_-* with fixup-* in lib-rebase.sh
> > > * fixup a small nit in Documentation
> >
> > These changes are still worthwhile and can easily be done
> > incrementally atop what is already in next, I would think.
>
> I agree, these fixes are required. So, I am not sure but now to do these
> fixup shall I send another patch cleaning this patch series(v4) and rebase the
> patch on the 'next' branch ? Is it the right way ?

Yeah, I think you can send each of the above 3 changes in a different patch on top of the 'next' branch. That would create a new 3 patch long series, which you should give a new name and not consider v5 of the previous patch series.

Best, Christian.