Re: [PATCH v2 9/9] doc/git-rebase: add documentation for fixup [-C|-c] options

From: Charvi Mendiratta <charvi077@gmail.com>
Date: Jan 20, 2021, 12:31 UTC
Message-ID: <CAPSFM5f9JJk5xY-f2mNwHjZZfo-=LzSCpA2Q73T-ASGMxfqqeg@mail.gmail.com>
In-Reply-To: <7c11da69-d2f1-0aab-80bc-d8ae8735f8ca@gmail.com>

Hi Phillip,

On Wed, 20 Jan 2021 at 16:34, Phillip Wood <phillip.wood123@gmail.com> wrote:

Show 10 quoted lines

> >[...]
> > Similarly, if we have sequence like `fixup -c`, `fixup -c`, `fixup -c`
> > then also it will fixup
> > up all the content and here it allow user to edit the message, so
> > opens the editor once
>
> It is good that we only open the editor once in this case - I'd not
> thought about chains of `fixup -c` before reading this. Do we have a
> test to verify that the editor is only opened once?
>

No, we don't. But I also agree, it's a good idea to add a test for it. I think may be one sequence with 'fixup -C', 'fixup -c', 'fixup -c' and the other 'squash' , 'fixup -C', 'fixup -c', is sufficient for testing. Or any other suggestions for testing it ?

Thanks and regards, Charvi