Re: [RFC PATCH 5/9] sequencer: use const variable for commit message comments

From: Christian Couder <christian.couder@gmail.com>
Date: Jan 14, 2021, 07:40 UTC
Message-ID: <CAP8UFD3yhh+UO+pQ9Zr5Rwxy8ma1HENq5dNuani3qyJBYiBKkg@mail.gmail.com>
In-Reply-To: <xmqqv9c0wp2i.fsf@gitster.c.googlers.com>

On Wed, Jan 13, 2021 at 9:37 PM Junio C Hamano <gitster@pobox.com> wrote:

>
> Taylor Blau <me@ttaylorr.com> writes:

[...]

Show 12 quoted lines

> > The other nitpick
> > is that its typical to see 'char *foo' instead of 'char foo[]'.
> >
> > So, I'd write these as:
> >
> >     static const char *first_commit_msg_str = N_("This is the 1st commit message:");
> >     static const char *nth_commit_msg_fmt = N_("This is the commit message #%d:");
> >     static const char *skip_nth_commit_msg_fmt = N_("The commit message #%d will be skipped:");
> >     static const char *combined_commit_msg_str = N_("This is a combination of %d commits.");
>
> I actually am OK with []; it saves sizeof(char*) bytes from each of
> the variable, doesn't it?

Yeah, that's my understanding too.