Re: [PATCH 2/2] fsck: use oidset for skiplist

From: René Scharfe <l.s.r@web.de>
Date: Aug 13, 2018, 23:09 UTC
Message-ID: <fc24f963-1bca-a638-e292-71044057dabb@web.de>
In-Reply-To: <xmqqd0um3rhx.fsf@gitster-ct.c.googlers.com>

Am 13.08.2018 um 23:07 schrieb Junio C Hamano:

Show 14 quoted lines

> René Scharfe <l.s.r@web.de> writes:
> 
>> the mailing list [1], nor on the web interface [2].  The latter shows
>> extra spaces on the context lines of the first hunk, though, which I
>> can't see anywhere else.  All the lines look fine in the citation of
>> Ramsay's reply [3].  So I don't know where these extra spaces are
>> coming from. :-/
> 
> Hmph, interesting.
> 
> https://public-inbox.org/git/54a5367f-f832-402c-f51b-3225c92b41ad@web.de/raw
> 
> has "Content-Type: text/plain; charset=utf-8; format=flowed".  That
> page's rendition is more faithful to the bare text.

That explains it: Thunderbird 60 disables most older Add-ons, among them Toggle Word Wrap, which used to turn off format=flowed for me. I did that now using the config settings mailnews.send_plaintext_flowed and mailnews.display.disable_format_flowed_support.

> The funky " -" one I showed was what Gnus/Emacs came up with as the
> result of its best effort to make the format=flawed into something
> closer to "text", I think X-<.

Sorry. :(

> In any case, I do not think format=flowed can be reverted reliably
> (or can it be?  If so we should teach mailinfo to repair them).

RFC3676 gives me a headache, perhaps I should go to bed. If we can assume that lines don't have trailing spaces originally then we should be able to reconstruct their contents, no? "A generating agent SHOULD: [...] Trim spaces before user-inserted hard line breaks.", i.e. lines with trailing spaces are doomed to truncation without hope for repair.

René