Re: [PATCH 2/2] fsck: use oidset for skiplist

From: René Scharfe <l.s.r@web.de>
Date: Aug 13, 2018, 20:26 UTC
Message-ID: <49564417-fac3-ede2-7fd1-e3a5a03e4cfe@web.de>
In-Reply-To: <xmqqmutq5cpo.fsf@gitster-ct.c.googlers.com>

Am 13.08.2018 um 20:43 schrieb Junio C Hamano:

Show 18 quoted lines

> René Scharfe <l.s.r@web.de> writes:
> 
>> @@ -182,19 +181,10 @@ static int fsck_msg_type(enum fsck_msg_id msg_id,
>>   static void init_skiplist(struct fsck_options *options, const char
>> *path)
>>   {
>> -	static struct oid_array skiplist = OID_ARRAY_INIT;
>> -	int sorted;
>>   	FILE *fp;
>>   	struct strbuf sb = STRBUF_INIT;
>>   	struct object_id oid;
>>   -	if (options->skiplist)
>> -		sorted = options->skiplist->sorted;
>> -	else {
> 
> That SP before '-' on the removed line is the most curious aspect of
> this patch; I do not recall the last time I saw a corrupt patch from
> you---changed where you read/write your mails recently?

Well, I updated Thunderbird to version 60 a few days ago, but I can't see that extra space in my Sent folder, nor via the NNTP interface of the mailing list [1], nor on the web interface [2]. The latter shows extra spaces on the context lines of the first hunk, though, which I can't see anywhere else. All the lines look fine in the citation of Ramsay's reply [3]. So I don't know where these extra spaces are coming from. :-/

René

[1] news://news.public-inbox.org:119/54a5367f-f832-402c-f51b-3225c92b41ad@web.de [2] https://public-inbox.org/git/54a5367f-f832-402c-f51b-3225c92b41ad@web.de/ [3] https://public-inbox.org/git/bc9f21c6-b362-2e3f-1820-7da93a76a7c8@ramsayjones.plus.com/