Re: [PATCH 2/2] fsck: use oidset for skiplist

From: Jeff King <peff@peff.net>
Date: Aug 14, 2018, 02:01 UTC
Message-ID: <20180814020100.GB27055@sigill.intra.peff.net>
In-Reply-To: <8c5b2783-a08b-4ea4-3d69-8ae80582b5e3@web.de>

On Mon, Aug 13, 2018 at 07:15:19PM +0200, René Scharfe wrote:

Show 7 quoted lines

> Getting sidetracked here, but the following patch helps both sides a bit:
> 
> -- >8 --
> Subject: [PATCH] cat-file: reuse strbuf in batch_object_write()
> 
> Avoid allocating and then releasing memory for constructing the output
> for each object by reusing the strbuf for all of them.

Thanks, this an easy and sensible optimization. I have a few patches to send on top of my cat-file topic, so I'll pick this up there.

-Peff