Re: [PATCH 1/2] fsck: use strbuf_getline() to read skiplist file

From: René Scharfe <l.s.r@web.de>
Date: Aug 11, 2018, 21:00 UTC
Message-ID: <e3c1290a-27d9-0aba-76f7-0d4b8c11c045@web.de>
In-Reply-To: <20180811164856.GB27393@sigill.intra.peff.net>

Am 11.08.2018 um 18:48 schrieb Jeff King:

> And one I'm not sure about:
> 
>   - a read() error will now be quietly ignored; I guess we'd have to
>     check ferror(fp) to cover this. I'm not sure if it matters.

I'm not sure, either. It would catch media errors or file system corruption, right? Sounds useful, actually. We should check the other callers of strbuf_getline and friends as well, though, as reporting such errors seems to be omitted in most cases:

	$ git grep strbuf_getline | wc -l
	99
	$ git grep ferror | wc -l
	35

René