git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 7/7] Factor ref updating out of fetch_with_import

From
Sverre Rabbelier <srabbelier@gmail.com>
Date
Oct 29, 2009, 15:53 UTC
Message-ID
<fabb9a1e0910290853p49070443v6d6bf2bf75faf80@mail.gmail.com>
In-Reply-To
<20091029142232.GS10505@spearce.org>
Heya,
On Thu, Oct 29, 2009 at 07:22, Shawn O. Pearce <spearce@spearce.org> wrote:
> Please define a transport_update_refs wrapper function to implement
> this method invocation on the transport instance.  Callers should
> not be reaching into the struct transport directly.

With pleasure, should the transport_update_refs wrapper simply 'return 1' without doing anything if transport->update_refs is not set?

> I certainly have to wonder... if this is done in both fetch and
> clone, why isn't it just part of fetch_refs?
Because clone does not use fetch_refs, or am I missing something?
> Please set this before the disconnect method (move it up one line).
Will do.
-- 
Cheers,

Sverre Rabbelier
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 9 of 17 in “Prepare git-remote-helpers series for hg support”
  1. 0/7 Prepare git-remote-helpers series for hg supportSverre Rabbelier, Oct 29, 2009
  2. 2/7 .gitignore: add git-remote-cvsSverre Rabbelier, Oct 29, 2009
  3. 3/7 Add notify and warn to util.pySverre Rabbelier, Oct 29, 2009
  4. 4/7 Allow both url and foreign vcs in remote configSverre Rabbelier, Oct 29, 2009
  5. 5/7 Finally make remote helper support usefulSverre Rabbelier, Oct 29, 2009
  6. 6/7 When updating refs after a fetch, resolve the symref if setSverre Rabbelier, Oct 29, 2009
  7. 7/7 Factor ref updating out of fetch_with_importSverre Rabbelier, Oct 29, 2009
  8. Shawn O. PearceOct 29, 2009
  9. Sverre RabbelierOct 29, 2009
  10. Shawn O. PearceOct 29, 2009
  11. Sverre RabbelierOct 29, 2009
  12. Daniel BarkalowOct 29, 2009
  13. Sverre RabbelierOct 29, 2009
  14. Daniel BarkalowOct 29, 2009
  15. Sverre RabbelierOct 29, 2009
  16. Johan HerlandOct 29, 2009
  17. Sverre RabbelierOct 29, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.