git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/7] Refactor git_remote_cvs to a more generic git_remote_helpers

From
Johan Herland <johan@herland.net>
Date
Oct 29, 2009, 12:05 UTC
Message-ID
<200910291305.26523.johan@herland.net>
In-Reply-To
<1256798426-21816-2-git-send-email-srabbelier@gmail.com>
On Thursday 29 October 2009, Sverre Rabbelier wrote:
Show 9 quoted lines
> This in an effort to allow future remote helpers written in python to
> re-use the non-cvs-specific code.
> 
> Signed-off-by: Sverre Rabbelier <srabbelier@gmail.com>
> CC: Johan Herland <johan@herland.net>
> ---
> 
> 	As discussed with Johan Herland, refactored git_remote_cvs into a
> 	more reusable git_remote_helpers module.
It's hard to review this patch for a couple of reasons:
1. It's over 200K large, which causes it to be blocked by the Git mailing 
list (100K limit, I believe).
2. The patch renames some files, but instead of simply stating the rename, 
the patch lists the entire file twice (deletion + creation)

Fortunately, you can easily solve both problems by rerolling the patch with the -M flag to git-format-patch.

...Johan
-- 
Johan Herland, <johan@herland.net>
www.herland.net
Previous: Sverre RabbelierNext: Sverre Rabbelier
Message 16 of 17 in “Prepare git-remote-helpers series for hg support”
  1. 0/7 Prepare git-remote-helpers series for hg supportSverre Rabbelier, Oct 29, 2009
  2. 2/7 .gitignore: add git-remote-cvsSverre Rabbelier, Oct 29, 2009
  3. 3/7 Add notify and warn to util.pySverre Rabbelier, Oct 29, 2009
  4. 4/7 Allow both url and foreign vcs in remote configSverre Rabbelier, Oct 29, 2009
  5. 5/7 Finally make remote helper support usefulSverre Rabbelier, Oct 29, 2009
  6. 6/7 When updating refs after a fetch, resolve the symref if setSverre Rabbelier, Oct 29, 2009
  7. 7/7 Factor ref updating out of fetch_with_importSverre Rabbelier, Oct 29, 2009
  8. Shawn O. PearceOct 29, 2009
  9. Sverre RabbelierOct 29, 2009
  10. Shawn O. PearceOct 29, 2009
  11. Sverre RabbelierOct 29, 2009
  12. Daniel BarkalowOct 29, 2009
  13. Sverre RabbelierOct 29, 2009
  14. Daniel BarkalowOct 29, 2009
  15. Sverre RabbelierOct 29, 2009
  16. Johan HerlandOct 29, 2009
  17. Sverre RabbelierOct 29, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.