From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Thu, 29 Oct 2009 15:53:59 GMT
Subject: Re: [PATCH 7/7] Factor ref updating out of fetch_with_import
Message-ID: <fabb9a1e0910290853p49070443v6d6bf2bf75faf80@mail.gmail.com>
In-Reply-To: <20091029142232.GS10505@spearce.org>

Heya,

On Thu, Oct 29, 2009 at 07:22, Shawn O. Pearce <spearce@spearce.org> wrote:
> Please define a transport_update_refs wrapper function to implement
> this method invocation on the transport instance.  Callers should
> not be reaching into the struct transport directly.

With pleasure, should the transport_update_refs wrapper simply 'return
1' without doing anything if transport->update_refs is not set?

> I certainly have to wonder... if this is done in both fetch and
> clone, why isn't it just part of fetch_refs?

Because clone does not use fetch_refs, or am I missing something?

> Please set this before the disconnect method (move it up one line).

Will do.

-- 
Cheers,

Sverre Rabbelier