Re: [PATCH 7/7] Factor ref updating out of fetch_with_import

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Oct 29, 2009, 18:43 UTC
Message-ID: <alpine.LNX.2.00.0910291435180.14365@iabervon.org>
In-Reply-To: <fabb9a1e0910291039u3c9d7eb6qe36e25ea76cdddc9@mail.gmail.com>

On Thu, 29 Oct 2009, Sverre Rabbelier wrote:

Show 8 quoted lines

> Heya,
> 
> On Thu, Oct 29, 2009 at 10:22, Daniel Barkalow <barkalow@iabervon.org> wrote:
> > (a) if HEAD is determined to be a symref, and we care about HEAD, we care
> > about whatever HEAD is a symref to; wanted_peer_refs() shouldn't be
> > filtering such things out.
> 
> It seems that wanted_peer_refs filters out HEAD no matter what though?

It probably shouldn't. Actually, I bet Nico's clone will get extremely confused if the remote's HEAD isn't the same as any of its branches. I'll try to take a look tonight.

Show 8 quoted lines

> > (b) we don't want to make a whole bunch of copies of the ref list to avoid
> > updating the mutable ref list that we will look for updated values in; the
> > merge of my series with Nico's should replace my copy_ref_list with his
> > wanted_peer_refs, not include the copy afterwards. Correcting this should
> > lead to the value that matters in the list that will be used having been
> > updated directly by transport_fetch_refs().
> 
> This I can and will fix. Patch-bomb incoming.

I'll look over it later, thanks.

	-Daniel
*This .sig left intentionally blank*