Re: [PATCH v4 0/3] sequencer: comment out properly in todo list

From: Kristoffer Haugsbakk <code@khaugsbakk.name>
Date: Nov 27, 2024, 12:39 UTC
Message-ID: <fa5d351c-627f-43e2-b001-ac12ea92a54b@app.fastmail.com>
In-Reply-To: <da8e283d-e749-4faa-b18b-fed9c51b0fbb@gmail.com>

On Tue, Nov 26, 2024, at 12:24, Phillip Wood wrote:

Show 18 quoted lines

> On 26/11/2024 01:11, Junio C Hamano wrote:
>> kristofferhaugsbakk@fastmail.com writes:
>>
>>> From: Kristoffer Haugsbakk <code@khaugsbakk.name>
>>>
>>> Fix three places where the comment char/string is hardcoded (#) in the
>>> todo list.
>>>
>>> § Changes in v4
>>>
>>> • Use `test_grep`
>>> • Fix commit message (`)
>>> • Don’t need to cat(1)
>>>    • Also use `-n4` in case `-4` is not widely supported
>>
>> All changes make sense.  Will queue.
>
> This version looks good to me too, thanks for working on it Kristoffer

Thanks for the reviews and for finishing the last test coverage in this series (fixup -c/-C). I was not familiar with that code as a user so I didn’t know what was expected.

Cheers

-- 
Kristoffer