Re: [PATCH] sequencer: comment checked-out branch properly

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 23, 2024, 20:43 UTC
Message-ID: <ZxlgDqZuBbwqXMch@nand.local>
In-Reply-To: <5267b9a9c8cc5cc66979117dc4c1e4d7329e2a03.1729704370.git.code@khaugsbakk.name>

On Wed, Oct 23, 2024 at 07:27:58PM +0200, kristofferhaugsbakk@fastmail.com wrote:

>  sequencer.c       |  5 +++--
>  t/t3400-rebase.sh | 16 ++++++++++++++++
>  2 files changed, 19 insertions(+), 2 deletions(-)

I should have thought to mention this earlier, but this does not easily integrate into 'seen' because of 'jc/strbuf-commented-something', which turns, for e.g.:

    strbuf_add_commented_lines(&cbuf, buf.buf, buf.len, comment_line_str);

into:

    strbuf_add_comment_lines(&cbuf, buf.buf, buf.len);

Note that the function is both renamed, and already knows about comment_line_str, so it is not necessary to pass it in as an argument explicitly.

Perhaps you may want to rebuild your topic on that one?

Thanks, Taylor