Re: [PATCH v2 3/3] sequencer: comment commit messages properly

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Nov 24, 2024, 19:58 UTC
Message-ID: <abd3987a-79a8-4e7b-9737-4413a56e288c@app.fastmail.com>
In-Reply-To: <711b59d7-e649-4031-8924-a16fb632b4d4@gmail.com>

On Wed, Nov 13, 2024, at 15:49, phillip.wood123@gmail.com wrote:

Show 22 quoted lines

> On 13/11/2024 01:03, Junio C Hamano wrote:
>> kristofferhaugsbakk@fastmail.com writes:
>>
>>> From: Kristoffer Haugsbakk <code@khaugsbakk.name>
>>>
>>
>> Describe what happens when a custom comment string is used without
>> the fixed code in this space.
>
> It would also be helpful to explain how to trigger the bug [1]
>
> If I remember correctly it was Taylor who first noticed this [2]. If so
> we should credit him with a "Reported-by:" trailer.
>
>>> Co-authored-by: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> It seems odd to me to have a "Co-authored-by:" trailer without a
> corresponding "Signed-off-by:" If someone has contributed enough to
> deserve "Co-authored-by:" then they should be signing off the code they
> have contributed. In this case I'd be happy with "Helped-by:" instead
> but feel free to add my "Signed-off-by:" if you want to keep
> "Co-authored-by:".

I’ll fix that in the next version.  Thanks.