git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] mingw: hot-fix t5615

From
Johannes Sixt <j6t@kdbg.org>
Date
Nov 11, 2016, 17:11 UTC
Message-ID
<fa11def5-a878-a5c8-6e7b-627ea8cda7e2@kdbg.org>
In-Reply-To
<xmqq37iy3q0s.fsf@gitster.mtv.corp.google.com>
Am 11.11.2016 um 18:06 schrieb Junio C Hamano:
Show 23 quoted lines
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>
>> That test made the incorrect assumption that the path separator character
>> is always a colon. On Windows, it is a semicolon instead.
>
> Documentation/git.txt says that GIT_ALTERNATE_OBJECT_DIRECTORIES is
> separated with ";" on Windows fairly clearly, and we should have
> caught that.
>
> For the upcoming release there is no need for any further tweak on
> your fix I am responding to, but in the longer term we would want to
> turn this to path_sep=";" (or ":") and define it in the global
> t/test-lib.sh, as it is plausible that we may want to prepend or
> append to $PATH in the tests and that also needs ";" on Windows, no?
>
> Are there other variables that is a list of paths that we care in
> our tests?  I notice GIT_CEILING_DIRECTORIES does not have the
> corresponding ": separated (on windows ; separated) list" in its
> description in Documentation/git.txt but the documentation may need
> to be fixed there as well?
>
> Thanks for a quick fix.  Will apply on jk/alt-odb-cleanup and merge
> down.

A simpler fix is to use $PWD instead of $(pwd). I'll submit a patch in a moment.

-- Hannes
Previous: Junio C HamanoNext: Johannes Sixt
Message 3 of 17 in “mingw: hot-fix t5615”
  1. mingw: hot-fix t5615Johannes Schindelin, Nov 11, 2016
  2. Junio C HamanoNov 11, 2016
  3. Johannes SixtNov 11, 2016
  4. t0021, t5615: use $PWD instead of $(pwd) in PATH-like shell variablesJohannes Sixt, Nov 11, 2016
  5. Jeff KingNov 11, 2016
  6. Junio C HamanoNov 11, 2016
  7. Johannes SchindelinNov 12, 2016
  8. Junio C HamanoNov 13, 2016
  9. Lars SchneiderNov 14, 2016
  10. Torsten BögershausenNov 14, 2016
  11. Jeff KingNov 14, 2016
  12. Ramsay JonesNov 14, 2016
  13. Junio C HamanoNov 14, 2016
  14. Johannes SchindelinNov 15, 2016
  15. Johannes SchindelinNov 16, 2016
  16. Junio C HamanoNov 16, 2016
  17. Jeff KingNov 11, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.