Re: [PATCH] t0021, t5615: use $PWD instead of $(pwd) in PATH-like shell variables

From: Lars Schneider <larsxschneider@gmail.com>
Date: Nov 14, 2016, 09:11 UTC
Message-ID: <0BEC2674-20B5-4AD1-851A-97CA34C0CE7F@gmail.com>
In-Reply-To: <xmqqtwbcyyfe.fsf@gitster.mtv.corp.google.com>

Show 17 quoted lines

> On 13 Nov 2016, at 02:13, Junio C Hamano <gitster@pobox.com> wrote:
> 
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
>>> Thanks.  Dscho, does this fix both of these issues to you?
>> 
>> Apparently it does because the CI jobs for `master` and for `next` pass.
> 
> OK, thanks for a quick confirmation.
> 
>> The one for `pu` still times out, of course.
> 
> Earlier you said 'pu' did even not build, but do we know where this
> "still times out" comes from?  As long as I don't merge anything
> prematurely, which I need to be careful about, it shouldn't impact
> the upcoming release, but we'd need to figure it out before moving
> things forward post release.

What is the goal for 'pu'?

(1) Builds clean on all platforms + passes all tests (2) Builds clean on all platforms (3) Builds clean on Linux (4) Just makes new topics easily available to a broader audience

My understanding was always (4) but the discussion above sounds more like (1) or (2)?

--

Git 'pu' does not compile on macOS right now: builtin/bisect--helper.c:299:6: error: variable 'good_syn' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] ...

More info here: https://api.travis-ci.org/jobs/175417712/log.txt?deansi=true

--

Cheers, Lars