Re: [PATCH] t0021, t5615: use $PWD instead of $(pwd) in PATH-like shell variables

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 16, 2016, 09:47 UTC
Message-ID: <alpine.DEB.2.20.1611161041040.3746@virtualbox>
In-Reply-To: <alpine.DEB.2.20.1611151753300.3746@virtualbox>

Hi,

On Tue, 15 Nov 2016, Johannes Schindelin wrote:

Show 9 quoted lines

> On Mon, 14 Nov 2016, Junio C Hamano wrote:
> 
> > Dscho's mention of 'still times out' may be an indiciation that
> > something unspecified on 'pu' is not ready to be merged to 'next',
> > but blocking all of 'pu' with a blanket statement is not useful,
> > and that was where my response comes from.
> 
> Until the time when the test suite takes less than the insane three hours
> to run, I am afraid that a blanket statement on `pu` is the best I can do.

Well, I should add that the test suite does not take 3 hours to run for `pu` these days.

It used to time out after four hours until two days ago (I think; I was a bit too busy with other CI work to pay close attention to the constantly failing `pu` job, with quite a few failing `next`s and even a couple of failing `master`s thrown in).

As of two days ago, the test suite takes no time at all. The build already fails (which makes me wonder why a couple of patch series I contributed had such a hard time getting into `pu` when they compiled and tested just fine, whereas some obviously non-building stuff gets into `pu` already, makes no sense to me).

This is the offending part from last night's build:

-- snipsnap -- 2016-11-16T00:31:57.5321220Z copy.c: In function 'copy_dir_1': 2016-11-16T00:31:57.5321220Z copy.c:369:8: error: implicit declaration of function 'lchown' [-Werror=implicit-function-declaration] 2016-11-16T00:31:57.5321220Z if (lchown(dest, source_stat.st_uid, source_stat.st_gid) < 0) 2016-11-16T00:31:57.5321220Z ^~~~~~ 2016-11-16T00:31:57.5321220Z copy.c:391:7: error: implicit declaration of function 'mknod' [-Werror=implicit-function-declaration] 2016-11-16T00:31:57.5321220Z if (mknod(dest, source_stat.st_mode, source_stat.st_rdev) < 0) 2016-11-16T00:31:57.5321220Z ^~~~~ 2016-11-16T00:31:57.5321220Z copy.c:405:7: error: implicit declaration of function 'utimes' [-Werror=implicit-function-declaration] 2016-11-16T00:31:57.5321220Z if (utimes(dest, times) < 0) 2016-11-16T00:31:57.5321220Z ^~~~~~ 2016-11-16T00:31:57.5321220Z copy.c:407:7: error: implicit declaration of function 'chown' [-Werror=implicit-function-declaration] 2016-11-16T00:31:57.5321220Z if (chown(dest, source_stat.st_uid, source_stat.st_gid) < 0) { 2016-11-16T00:31:57.5321220Z ^~~~~ 2016-11-16T00:31:57.7982432Z CC ctype.o 2016-11-16T00:31:58.1418929Z cc1.exe: all warnings being treated as errors 2016-11-16T00:31:58.6368128Z make: *** [Makefile:1988: copy.o] Error 1