From: Johannes Sixt <j6t@kdbg.org>
Date: Fri, 11 Nov 2016 17:11:02 GMT
Subject: Re: [PATCH] mingw: hot-fix t5615
Message-ID: <fa11def5-a878-a5c8-6e7b-627ea8cda7e2@kdbg.org>
In-Reply-To: <xmqq37iy3q0s.fsf@gitster.mtv.corp.google.com>

Am 11.11.2016 um 18:06 schrieb Junio C Hamano:
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>
>> That test made the incorrect assumption that the path separator character
>> is always a colon. On Windows, it is a semicolon instead.
>
> Documentation/git.txt says that GIT_ALTERNATE_OBJECT_DIRECTORIES is
> separated with ";" on Windows fairly clearly, and we should have
> caught that.
>
> For the upcoming release there is no need for any further tweak on
> your fix I am responding to, but in the longer term we would want to
> turn this to path_sep=";" (or ":") and define it in the global
> t/test-lib.sh, as it is plausible that we may want to prepend or
> append to $PATH in the tests and that also needs ";" on Windows, no?
>
> Are there other variables that is a list of paths that we care in
> our tests?  I notice GIT_CEILING_DIRECTORIES does not have the
> corresponding ": separated (on windows ; separated) list" in its
> description in Documentation/git.txt but the documentation may need
> to be fixed there as well?
>
> Thanks for a quick fix.  Will apply on jk/alt-odb-cleanup and merge
> down.

A simpler fix is to use $PWD instead of $(pwd). I'll submit a patch in a 
moment.

-- Hannes