Re: [ANNOUNCE] Git v2.50.0-rc1 - Test Failed

From: Johannes Sixt <j6t@kdbg.org>
Date: Jun 5, 2025, 21:11 UTC
Message-ID: <f2ed8920-347d-45d3-a0bb-df94ece0d9df@kdbg.org>
In-Reply-To: <014201dbd658$4da75680$e8f60380$@nexbridge.com>

Am 05.06.25 um 22:27 schrieb rsbecker@nexbridge.com:

Show 12 quoted lines

> The *.tcl files in git-gui/lib are gone after the above command. I noticed a
> few things run by the above - this did not happen in 2.49.
> 
> /usr/coreutils/bin/make -C git-gui
> gitexecdir='/usr/local-ssl3.5/libexec/git-core' all
> make[1]: Entering directory
> '/home/jenkinsbuild/.jenkins/workspace/Git_Pipeline/git-gui'
> GITGUI_VERSION=0.21.GITGUI
> /usr/coreutils/bin/bash generate-git-gui.sh "git-gui.sh" "git-gui"
> ./GIT-GUI-BUILD-OPTIONS ./GIT-VERSION-FILE
> /usr/coreutils/bin/bash generate-tclindex.sh . ./GIT-GUI-BUILD-OPTIONS
> lib/merge.tcl lib/error.tcl lib/chord.tcl lib/date.tcl lib/encoding.tcl

...

Show 5 quoted lines

> generate-tclindex.sh: line 21: tclsh: command not found
>     * tclsh failed; using unoptimized loading
> 
> It appears the above removes the *.tcl files. That causes the subsequent
> failure.

Interesting. We have this in generate-tclindex.sh:

...
else
         echo >&2 "    * $TCL_PATH failed; using unoptimized loading"
         rm -f $@
         echo '# Autogenerated by git-gui Makefile' >lib/tclIndex
...

This $@ was taken literally from the Makefile, where it means something very different than in the shell script. The line could be

         rm -f lib/tclIndex

or it could be deleted because the next line overwrites the file anyway.

In the meantime, setting NO_TCLTK=NoThanks in config.mak is probably the quickest fix for you.

Thank you for the report. -- Hannes