[GIT PULL] git-gui: fix for: [ANNOUNCE] Git v2.50.0-rc1 - Test Failed

From: Johannes Sixt <j6t@kdbg.org>
Date: Jun 6, 2025, 05:57 UTC
Message-ID: <4f390ad8-6c30-493c-952e-d1f079a7f6ac@kdbg.org>
In-Reply-To: <xmqqikl97u1l.fsf@gitster.g>

The following changes since commit 61f8788fe9d362efb112f69a58cf0510a7e49ee0:

  Merge branch 'pks-meson-support' of github.com:pks-t/git-gui (2025-05-29 10:01:14 +0200)

are available in the Git repository at:

  https://github.com/j6t/git-gui.git master

for you to fetch changes up to 765f1db2b5a890c0fa01f8976f197a8483357afe:

  git-gui: don't delete source files when auto_mkindex fails (2025-06-06 07:43:37 +0200)

----------------------------------------------------------------
commit 765f1db2b5a890c0fa01f8976f197a8483357afe
Author: Johannes Sixt <j6t@kdbg.org>
Date:   Fri Jun 6 07:41:42 2025 +0200

    git-gui: don't delete source files when auto_mkindex fails
    
    Commit 2cc5b0facfa4 (git-gui: extract script to generate "tclIndex",
    2025-03-11) converted commands in a Makefile rule to a shell script.
    In this process, the Makefile variable $@ had to be replaced by the
    file name that it represents, 'lib/tclIndex'. However, the occurrence
    in `rm -f $@` was missed. In a shell script, $@ expands to all
    command line arguments, which happen to be the source files lib/*.tcl
    in this case. Needless to say that we do not want to remove source
    files during a build. Replace $@ by the intended 'lib/tclIndex'.
    
    Reported-by: Randall S. Becker <rsbecker@nexbridge.com>
    Signed-off-by: Johannes Sixt <j6t@kdbg.org>

diff --git a/generate-tclindex.sh b/generate-tclindex.sh
index 36e3a0bd90ee..0b031d8339c4 100755
--- a/generate-tclindex.sh
+++ b/generate-tclindex.sh
@@ -23,7 +23,7 @@ then
 	: ok
 else
 	 echo >&2 "    * $TCL_PATH failed; using unoptimized loading"
-	 rm -f $@
+	 rm -f lib/tclIndex
 	 echo '# Autogenerated by git-gui Makefile' >lib/tclIndex
 	 echo >>lib/tclIndex
 	 echo "class.tcl" >>lib/tclIndex