git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: [ANNOUNCE] Git v2.50.0-rc1 - Test Failed

From
rsbecker@nexbridge.com <rsbecker@nexbridge.com>
Date
Jun 5, 2025, 21:44 UTC
Message-ID
<014f01dbd663$0ef73530$2ce59f90$@nexbridge.com>
In-Reply-To
<f2ed8920-347d-45d3-a0bb-df94ece0d9df@kdbg.org>
On June 5, 2025 5:12 PM, Johannes Sixt wrote:
Show 39 quoted lines
>Am 05.06.25 um 22:27 schrieb rsbecker@nexbridge.com:
>> The *.tcl files in git-gui/lib are gone after the above command. I
>> noticed a few things run by the above - this did not happen in 2.49.
>>
>> /usr/coreutils/bin/make -C git-gui
>> gitexecdir='/usr/local-ssl3.5/libexec/git-core' all
>> make[1]: Entering directory
>> '/home/jenkinsbuild/.jenkins/workspace/Git_Pipeline/git-gui'
>> GITGUI_VERSION=0.21.GITGUI
>> /usr/coreutils/bin/bash generate-git-gui.sh "git-gui.sh" "git-gui"
>> ./GIT-GUI-BUILD-OPTIONS ./GIT-VERSION-FILE /usr/coreutils/bin/bash
>> generate-tclindex.sh . ./GIT-GUI-BUILD-OPTIONS lib/merge.tcl
>> lib/error.tcl lib/chord.tcl lib/date.tcl lib/encoding.tcl
>...
>> generate-tclindex.sh: line 21: tclsh: command not found
>>     * tclsh failed; using unoptimized loading
>>
>> It appears the above removes the *.tcl files. That causes the
>> subsequent failure.
>
>Interesting. We have this in generate-tclindex.sh:
>
>...
>else
>         echo >&2 "    * $TCL_PATH failed; using unoptimized loading"
>         rm -f $@
>         echo '# Autogenerated by git-gui Makefile' >lib/tclIndex ...
>
>This $@ was taken literally from the Makefile, where it means something very
>different than in the shell script. The line could be
>
>         rm -f lib/tclIndex
>
>or it could be deleted because the next line overwrites the file anyway.
>
>In the meantime, setting NO_TCLTK=NoThanks in config.mak is probably the
>quickest fix for you.
>
>Thank you for the report.
Can I pass this in via command line? Instead of modifying config.mak?
Previous: Johannes SixtNext: Junio C Hamano
Message 14 of 17 in “[ANNOUNCE] Git v2.50.0-rc1”
  1. Junio C HamanoJun 3, 2025
  2. rsbecker@nexbridge.comJun 3, 2025
  3. rsbecker@nexbridge.comJun 3, 2025
  4. Todd ZullingerJun 4, 2025
  5. Junio C HamanoJun 4, 2025
  6. Johannes SixtJun 4, 2025
  7. rsbecker@nexbridge.comJun 5, 2025
  8. Patrick SteinhardtJun 5, 2025
  9. rsbecker@nexbridge.comJun 5, 2025
  10. Johannes SixtJun 5, 2025
  11. Junio C HamanoJun 5, 2025
  12. [GIT PULL] git-gui: fix for: [ANNOUNCE] Git v2.50.0-rc1 - Test FailedJohannes Sixt, Jun 6, 2025
  13. [GIT PULL] git-gui: Sync with 2.50.1, Tcl >= 8.6, git >= 2.36Johannes Sixt, Jul 22, 2025
  14. rsbecker@nexbridge.comJun 5, 2025
  15. Junio C HamanoJun 5, 2025
  16. 'Todd Zullinger'Jun 5, 2025
  17. rsbecker@nexbridge.comJun 6, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.