git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: [ANNOUNCE] Git v2.50.0-rc1 - Test Failed

From
rsbecker@nexbridge.com <rsbecker@nexbridge.com>
Date
Jun 5, 2025, 08:09 UTC
Message-ID
<010b01dbd5f1$3c26ec20$b474c460$@nexbridge.com>
In-Reply-To
<44fe8627-5680-443d-bf02-a6e85afd46b4@kdbg.org>
On June 4, 2025 3:25 PM, Johannes Sixt wrote:
Show 36 quoted lines
>Am 04.06.25 um 17:17 schrieb Junio C Hamano:
>> So the build procedure for git-gui (but not gitk) has changed rather
>> extensively after we tagged the preview before -rc1?  Honestly, I
>> would have preferred to see a change with this impact go through the
>> regular 'seen' to 'next' to 'master' way before -rc0, but that is
>> water under the bridge.
>
>I don't think we ever had such a cycle for gitk and git-gui. I carry inofficial branches
>'j6t-testing' in my repositories that interested parties could track instead of 'master'.
>I would be happy to hear that people actually do use them.
>
>> I do not spot anything obviously wrong (and it is not expected that I
>> would---we wouldn't have this code sent to me in the first place if
>> this is something I can immediately notice).  git-gui/Makefile sets
>> ALL_LIBFILES to $(wildcard lib/*.tcl) and then does
>>
>>     $(SHELL_PATH) generate-tclindex.sh . ./GIT-GUI-BUILD-OPTIONS
>> $(ALL_LIBFILES)
>>
>> So the error message in Becker's message, i.e.
>>
>>> /usr/coreutils/bin/bash generate-tclindex.sh .
>>> ./GIT-GUI-BUILD-OPTIONS
>>> usage: generate-tclindex.sh <BUILD_DIR> <BUILD_OPTIONS> <LIBFILE>
>>> [<LIBFILE>...]
>>> Makefile:200: recipe for target 'lib/tclIndex' failed
>>
>> suggests that $(wildcard lib/*tcl) expanded to *nothing*, which sounds
>> horribly wrong.  They are source material and should exist in an
>> unmodified checkout or a tarball extract.
>
>I don't see anything wrong, either. I can easily verify your theory that the
>$(wildcard) produces an empty list by modifying the pattern.
>
>Randall, would it be possible for you to find out why $(wildcard
>lib/*tcl) produces an empty list in your case?
I can verify that $(wildcard lib/*tcl) is correctly reporting an empty list.

There are three directories name lib in the 2.50.0-rc1 commit: ./git-gui/lib ./gitweb/static/js/lib ./perl/build/lib None have any files ending in tcl: $ ls git-gui/lib git-gui.ico meson.build tclIndex win32_shortcut.js $ ls gitweb/static/js/lib common-lib.js cookies.js datetime.js $ ls perl/build/lib FromCPAN Git Git.pm

If it possible that your workspace has extra stuff that does not exist at the time make is run. Note that I am using gnu Make 4.2.1 with bash to perform the built/test cycle.

Previous: Johannes SixtNext: Patrick Steinhardt
Message 7 of 17 in “[ANNOUNCE] Git v2.50.0-rc1”
  1. Junio C HamanoJun 3, 2025
  2. rsbecker@nexbridge.comJun 3, 2025
  3. rsbecker@nexbridge.comJun 3, 2025
  4. Todd ZullingerJun 4, 2025
  5. Junio C HamanoJun 4, 2025
  6. Johannes SixtJun 4, 2025
  7. rsbecker@nexbridge.comJun 5, 2025
  8. Patrick SteinhardtJun 5, 2025
  9. rsbecker@nexbridge.comJun 5, 2025
  10. Johannes SixtJun 5, 2025
  11. Junio C HamanoJun 5, 2025
  12. [GIT PULL] git-gui: fix for: [ANNOUNCE] Git v2.50.0-rc1 - Test FailedJohannes Sixt, Jun 6, 2025
  13. [GIT PULL] git-gui: Sync with 2.50.1, Tcl >= 8.6, git >= 2.36Johannes Sixt, Jul 22, 2025
  14. rsbecker@nexbridge.comJun 5, 2025
  15. Junio C HamanoJun 5, 2025
  16. 'Todd Zullinger'Jun 5, 2025
  17. rsbecker@nexbridge.comJun 6, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.