Re: [PATCH] gitweb: make leftmost column of blame less cluttered.

From: Jakub Narebski <jnareb@gmail.com>
Date: Oct 4, 2006, 03:07 UTC
Message-ID: <efv8fv$dvn$1@sea.gmane.org>
In-Reply-To: <20061004024837.4462.qmail@web31808.mail.mud.yahoo.com>

Luben Tuikov wrote:

Show 23 quoted lines

> --- Junio C Hamano <junkio@cox.net> wrote:
>> > I like the fact that the "data part" of blame is text, and
>> > that the commit-8 is on the left, and color-chunked.  Sometimes
>> > people simply _remember_ a number of commit-8's and thus the
>> > layout of blame is intentional, since they can look to the left
>> > and recognize a commit-8...
>> 
>> It is not only the initial commit.  A substantial rewrite and
>> new development also has the same issue.
>> 
>> I think you are also contradicting yourself by saying that
>> people would recognize a commit-8, and at the same time you do
>> not like the chunk code that makes sure you do not get too few
>> of them.  If people _do_ recognize commit-8 (I seriously doubt
>> that), then wouldn't it help to make sure you have them on every
>> couple-dozen lines so that the user would see the familiar one
>> even when scrolled?
> 
> It is not that I don't like it.  For example if we didn't have
> the block-per-commit-coloring, then we'd make use of this, but it
> seems that the block-per-commit-coloring exists for the purpose to
> show conglomerations of same-commit lines, thus obviating the need
> to repeat it (commit-8) every so many lines.

Colors repeat. They are not enough.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git