Re: [PATCH] gitweb: make leftmost column of blame less cluttered.

From: Luben Tuikov <ltuikov@yahoo.com>
Date: Oct 3, 2006, 19:01 UTC
Message-ID: <20061003190148.56650.qmail@web31805.mail.mud.yahoo.com>
In-Reply-To: <7vpsdat4ia.fsf@assigned-by-dhcp.cox.net>

--- Junio C Hamano <junkio@cox.net> wrote:

Show 7 quoted lines

> Luben Tuikov <ltuikov@yahoo.com> writes:
> > ACK.  Please commit.
> 
> Won't, at least as its current shape.  Somebody privately
> mentioned that the code risks slurping the entire file in the
> @chunk if it is untouched since the initial import, which is not
> what we want.

Indeed that's true.

Show 7 quoted lines

> The memory consumption worries aside, that would make the
> clickable commit object name to appear only very at the
> beginning of the page and would make it inconvenient to actually
> visit the commit after scrolling down to see later lines.
> 
> It might become usable if it is given a cap to limit the number
> of lines to put in a chunk.  I dunno.

I cannot imagine this to be a problem, since an initial commit is "very well known" (hopefully that makes sense to people using SCMs religously).

I'll give it try.
   Luben