Re: [PATCH] gitweb: make leftmost column of blame less cluttered.

From: Junio C Hamano <junkio@cox.net>
Date: Oct 3, 2006, 04:19 UTC
Message-ID: <7vpsdat4ia.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20061002192930.86293.qmail@web31803.mail.mud.yahoo.com>

Luben Tuikov <ltuikov@yahoo.com> writes:

Show 13 quoted lines

> --- Junio C Hamano <junkio@cox.net> wrote:
>
>> Instead of labelling each and every line with clickable commit
>> object name, this makes the blame output to show them only on
>> the first line of each group of lines from the same revision.
>> 
>> Also it makes mouse-over to show the minimum authorship and
>> authordate information for extra cuteness ;-).
>> 
>> Signed-off-by: Junio C Hamano <junkio@cox.net>
>> ---
>
> ACK.  Please commit.

Won't, at least as its current shape. Somebody privately mentioned that the code risks slurping the entire file in the @chunk if it is untouched since the initial import, which is not what we want.

The memory consumption worries aside, that would make the clickable commit object name to appear only very at the beginning of the page and would make it inconvenient to actually visit the commit after scrolling down to see later lines.

It might become usable if it is given a cap to limit the number of lines to put in a chunk. I dunno.