Re: [PATCH] gitweb: make leftmost column of blame less cluttered.

From: Junio C Hamano <junkio@cox.net>
Date: Oct 4, 2006, 02:26 UTC
Message-ID: <7virj0lsua.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20061003194551.70537.qmail@web31809.mail.mud.yahoo.com>

Luben Tuikov <ltuikov@yahoo.com> writes:

>> Then you don't need to worry about repeating the commit id,
>> and perhaps it is not even needed any more?

I am contradicting myself but I personally like what Pasky runs at http://repo.or.cz/ too, although it goes to the other extreme to spend more space for line-by-line annotation ;-)

Show 10 quoted lines

> I like Junio's first patch on the subject with the only
> objection that the "chunk" can be 100s of 1000s of lines
> if the file is too big and there had never been any changes
> since the initial commit.
>
> I like the fact that the "data part" of blame is text, and
> that the commit-8 is on the left, and color-chunked.  Sometimes
> people simply _remember_ a number of commit-8's and thus the
> layout of blame is intentional, since they can look to the left
> and recognize a commit-8...

It is not only the initial commit. A substantial rewrite and new development also has the same issue.

I think you are also contradicting yourself by saying that people would recognize a commit-8, and at the same time you do not like the chunk code that makes sure you do not get too few of them. If people _do_ recognize commit-8 (I seriously doubt that), then wouldn't it help to make sure you have them on every couple-dozen lines so that the user would see the familiar one even when scrolled?