Re: [PATCH v4 1/1] environment: move excludes_file into repo_config_values
- From
Tian Yuchen <cat@malon.dev>
- Date
- Jun 28, 2026, 03:38 UTC
- Message-ID
- <ef7f76d9-52f4-45c0-af0e-b7f3372b652a@malon.dev>
- In-Reply-To
- <eabb8169-2c13-4961-9b21-f44b1fa66f70@malon.dev>
On 6/28/26 11:19, Tian Yuchen wrote:
> Let it be noticed by repo_config_values() function to > catch offending callers for now, and once the codebase becomes ready > to use one repo_config_values per repository, this function does not > have to change.
And
Show 7 quoted lines
> Wouldn't we rather want to try to be more strict and say
>
> if (!repo || !repo->initialized)
> BUG("repo must be an initialied repository");
>
> here? Aren't all the callers of this function supposed to be
> dealing with an already initialized repository?In my opinion, these two suggestions are not entirely consistent, and I think we need to determine the most appropriate approach.
Regards, yuchen