From: Tian Yuchen Date: Sun, 28 Jun 2026 03:38:00 GMT Subject: Re: [PATCH v4 1/1] environment: move excludes_file into repo_config_values Message-ID: In-Reply-To: On 6/28/26 11:19, Tian Yuchen wrote: > Let it be noticed by repo_config_values() function to > catch offending callers for now, and once the codebase becomes ready > to use one repo_config_values per repository, this function does not > have to change. And > Wouldn't we rather want to try to be more strict and say > > if (!repo || !repo->initialized) > BUG("repo must be an initialied repository"); > > here? Aren't all the callers of this function supposed to be > dealing with an already initialized repository? In my opinion, these two suggestions are not entirely consistent, and I think we need to determine the most appropriate approach. Regards, yuchen