Re: [PATCH v2 1/2] dir: encapsulate excludes_file lazy-load
- From
SZEDER Gábor <szeder.dev@gmail.com>
- Date
- Jun 26, 2026, 21:14 UTC
- Message-ID
- <aj7rtj9NsejqN357@szeder.dev>
- In-Reply-To
- <20260626075037.532164-2-cat@malon.dev>
On Fri, Jun 26, 2026 at 03:50:36PM +0800, Tian Yuchen wrote:
Show 14 quoted lines
> diff --git a/environment.c b/environment.c
> index ba2c60103f..8efcaeafa6 100644
> --- a/environment.c
> +++ b/environment.c
> @@ -134,6 +134,13 @@ int is_bare_repository(void)
> return is_bare_repository_cfg && !repo_get_work_tree(the_repository);
> }
>
> +const char *repo_excludes_file(struct repository *repo)
> +{
> + if (!excludes_file)
> + excludes_file = xdg_config_home("ignore");
> + return excludes_file;
> +}This function has a 'repo' parameter, which is not used in the function at all. This causes build failure when trying to build this commit using DEVELOPER=1:
environment.c: In function ‘repo_excludes_file’:
environment.c:137:51: error: unused parameter ‘repo’ [-Werror=unused-parameter]
137 | const char *repo_excludes_file(struct repository *repo)
| ~~~~~~~~~~~~~~~~~~~^~~~
cc1: all warnings being treated as errors
make: *** [Makefile:2922: environment.o] Error 1Please make sure that all commits can be built with 'make DEVELOPER=1'.