Re: [PATCH v7 4/9] environment: move pager_program into repo_config_values
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 6, 2026, 17:38 UTC
- Message-ID
- <xmqqpl10auhw.fsf@gitster.g>
- In-Reply-To
- <20260706142530.3681520-5-cat@malon.dev>
Tian Yuchen <cat@malon.dev> writes:
Show 5 quoted lines
> if (data.value) > - pager_program = data.value; > + repo_config_values(r)->pager_program = data.value; > return data.want; > }
May not be a new problem, but does the old value or pager_program leak here, if callers call this function more than once (or pager_program gets assigned elsewhere)?