Re: [PATCH v2] config: avoid "write_in_full(fd, buf, len) < len" pattern

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Sep 13, 2017, 22:43 UTC
Message-ID: <ef20628e-b7c0-8909-31a0-cc126d0c40ba@ramsayjones.plus.com>
In-Reply-To: <20170913185848.5ht44spbakzkrsu6@sigill.intra.peff.net>

On 13/09/17 19:58, Jeff King wrote:

Show 24 quoted lines

> On Wed, Sep 13, 2017 at 11:24:31AM -0700, Jonathan Nieder wrote:
> 
>> For what it's worth,
>> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> 
> Thanks, and thank you for questioning the ptrdiff_t bits that didn't
> make sense. I _thought_ they felt like nonsense, but couldn't quite
> puzzle it out.
> 
>> Compilers' signed/unsigned comparison warning can be noisy, but I'm
>> starting to feel it's worth the suppression noise to turn it on when
>> DEVELOPER=1 anyway.  What do you think?  Is there a way to turn it on
>> selectively for certain functions on the LHS (like read() and write()
>> style functions)?
> 
> Obviously we couldn't turn them on for -Werror at this point. Let me see
> how bad "-Wsign-compare -Wno-error=sign-compare" is.
> 
>   $ make 2>&1 | grep -c warning:
>   1391
> 
> Ouch. I'm afraid that's probably not going to be very helpful. Even if I
> were introducing a new problem, I'm not likely to see it amidst the mass
> of existing complaints.

Hmm, about three or four years ago, I spent two or three evenings getting git to compile -Wextra clean. I remember the signed/unsigned issue was the cause of a large portion of the warnings issued by the compiler. I was surprised that it took such a relatively short time to do. However, it affected quite a large portion of the code, so I didn't think Junio would even consider applying it. Also, I only used gcc and was anticipating having additional warnings on clang (but I didn't get around to trying).

Maybe I should give it another go. :-D

ATB, Ramsay Jones