git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/7] gitweb: Cleanups, fixes and small improvements

From
Jakub Narebski <jnareb@gmail.com>
Date
Aug 27, 2006, 20:21 UTC
Message-ID
<ecsur8$gqh$1@sea.gmane.org>
In-Reply-To
<7vd5an1afz.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> * gitweb: Remove workaround for git-diff bug fixed in f82cd3c
> . gitweb: Fix typo in git_patchset_body
> 
>   I think you had separate patches for these; applied.

I think the second one, the one fixing typo ('@$fd>' instead of '= <$fd>') was not applied. I don't know how this typo got into gitweb, as I have tested gitweb after the 19-patch series, and this error looks was introduced in 'next' branch, 157e43b4b0dd5a08eb7a6838192ac58bca62fa5b commit

  gitweb: Streamify patch output in git_commitdiff
This error is critical!
-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Previous: Jakub Narebski
Message 11 of 11 in “gitweb: Cleanups, fixes and small improvements”
  1. 0/7 gitweb: Cleanups, fixes and small improvementsJakub Narebski, Aug 26, 2006
  2. 1/7 gitweb: Restore old git_blame using git-annotate under "annotate"Jakub Narebski, Aug 26, 2006
  3. 2/7 gitweb: Remove workaround for git-diff bug fixed in f82cd3cJakub Narebski, Aug 26, 2006
  4. 3/7 gitweb: Improve comments about gitweb features configurationJakub Narebski, Aug 26, 2006
  5. 4/7 gitweb: Fix typo in git_patchset_bodyJakub Narebski, Aug 26, 2006
  6. 5/7 gitweb: Use 'local $/ = undef;' before 'print <$fd>;'Jakub Narebski, Aug 26, 2006
  7. 6/7 gitweb: blobs defined by non-textual hash ids can be cachedJakub Narebski, Aug 26, 2006
  8. 7/7 gitweb: Always link to plain version of the blob in git_blob.Jakub Narebski, Aug 26, 2006
  9. Junio C HamanoAug 26, 2006
  10. Jakub NarebskiAug 26, 2006
  11. Jakub NarebskiAug 27, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.