git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/7] gitweb: Remove workaround for git-diff bug fixed in f82cd3c

From
Jakub Narebski <jnareb@gmail.com>
Date
Aug 26, 2006, 17:14 UTC
Message-ID
<11566124672654-git-send-email-jnareb@gmail.com>
In-Reply-To
<1156612392716-git-send-email-jnareb@gmail.com>
Remove workaround in git_blobdiff for error in git-diff (showing
reversed diff for diff of blobs), corrected in commit
 f82cd3c  Fix "git diff blob1 blob2" showing the diff in reverse.
which is post 1.4.2-rc2 commit.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
 gitweb/gitweb.perl |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index abd0f0d..df2f9e5 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2841,8 +2841,7 @@ sub git_blobdiff {
 		}
 
 		# open patch output
-		#open $fd, "-|", $GIT, "diff", '-p', $hash_parent, $hash
-		open $fd, "-|", $GIT, "diff", '-p', $hash, $hash_parent
+		open $fd, "-|", $GIT, "diff", '-p', $hash_parent, $hash
 			or die_error(undef, "Open git-diff failed");
 	} else  {
 		die_error('404 Not Found', "Missing one of the blob diff parameters")
-- 
1.4.1.1
Previous: Jakub NarebskiNext: Jakub Narebski
Message 3 of 11 in “gitweb: Cleanups, fixes and small improvements”
  1. 0/7 gitweb: Cleanups, fixes and small improvementsJakub Narebski, Aug 26, 2006
  2. 1/7 gitweb: Restore old git_blame using git-annotate under "annotate"Jakub Narebski, Aug 26, 2006
  3. 2/7 gitweb: Remove workaround for git-diff bug fixed in f82cd3cJakub Narebski, Aug 26, 2006
  4. 3/7 gitweb: Improve comments about gitweb features configurationJakub Narebski, Aug 26, 2006
  5. 4/7 gitweb: Fix typo in git_patchset_bodyJakub Narebski, Aug 26, 2006
  6. 5/7 gitweb: Use 'local $/ = undef;' before 'print <$fd>;'Jakub Narebski, Aug 26, 2006
  7. 6/7 gitweb: blobs defined by non-textual hash ids can be cachedJakub Narebski, Aug 26, 2006
  8. 7/7 gitweb: Always link to plain version of the blob in git_blob.Jakub Narebski, Aug 26, 2006
  9. Junio C HamanoAug 26, 2006
  10. Jakub NarebskiAug 26, 2006
  11. Jakub NarebskiAug 27, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.