Re: [PATCH 0/7] gitweb: Cleanups, fixes and small improvements

Jakub Narebski <jnareb@gmail.com> writes:

* gitweb: Restore old git_blame using git-annotate under "annotate"

  I actually was hoping to see a patch to remove the git_blame
  which is not used as far as I can see.

  Although we carried annotate and blame in git.git tree for
  quite a while, the intention was always to deprecate one over
  the other once pros-and-cons of each implementation become
  clear (and I think people would not miss annotate if we remove 
  annotate and make it an alias for blame -c anymore).  What's
  the reason we would want to have both?

* gitweb: Remove workaround for git-diff bug fixed in f82cd3c
. gitweb: Fix typo in git_patchset_body

  I think you had separate patches for these; applied.

* gitweb: Use 'local $/ = undef;' before 'print <$fd>;'

  You changed:

	$/ = undef;
	print <$fd>;
        ... hope that nobody depends on standard value of $/
	... around here, which may still break if you did sub
	... calls, the sub did not localize $/ (who would?),
        ... and depended to have a sane $/.
	$/ = "\n";

  to

	local $/ = undef;
	print <$fd>;
        ... hope that nobody depends on standard value of $/
	... until the end of scope, and whoever changes this
        ... sub is careful enough in the future

  which I think is worse.  Introducing an extra scope explicitly
  delimit the part you want to use localized $/ like this

	{ local $/; print <$fd>; } 

  might have been more palatable.  Am I guessing the reason of
  your change wrong?

* gitweb: Always link to plain version of the blob

  Needs a better description to justify the change by describing
  in what way the current implementation is broken.

The ones above I won't apply just yet (I first applied, merged into "next" and then commented on the earlier 19 series, but I'm not going to repeat that mistake again this time).

The rest look OK so I'll apply them; [6/7] depended on [5/7] so I manually adjusted the context.